This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 522
fix: remove Azure agent specific artifacts from windows vhd #2088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackfrancis
changed the title
Bug: Remove Azure agent specific artifacts from windows vhd
bug: Remove Azure agent specific artifacts from windows vhd
Oct 2, 2019
Codecov Report
@@ Coverage Diff @@
## master #2088 +/- ##
=========================================
- Coverage 76.65% 76.6% -0.05%
=========================================
Files 135 135
Lines 20576 20606 +30
=========================================
+ Hits 15773 15786 +13
- Misses 3881 3897 +16
- Partials 922 923 +1 |
rjaini
changed the title
bug: Remove Azure agent specific artifacts from windows vhd
[WIP]: Remove Azure agent specific artifacts from windows vhd
Oct 3, 2019
/lgtm |
rjaini
changed the title
[WIP]: Remove Azure agent specific artifacts from windows vhd
Bug: Remove Azure agent specific artifacts from windows vhd
Oct 3, 2019
mboersma
changed the title
Bug: Remove Azure agent specific artifacts from windows vhd
fix: remove Azure agent specific artifacts from windows vhd
Oct 3, 2019
mboersma
approved these changes
Oct 3, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm++
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marosset, mboersma, rjaini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
As part of windows VHD preparation certain Azure agents gets install which should be removed from VHD so that VHD can be consumed across platform (Azure, Azure Stack)
Issue Fixed:
Fixes #2086
Requirements:
Notes: