Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

fix: remove Azure agent specific artifacts from windows vhd #2088

Merged
merged 7 commits into from
Oct 3, 2019

Conversation

rjaini
Copy link
Contributor

@rjaini rjaini commented Oct 2, 2019

Reason for Change:
As part of windows VHD preparation certain Azure agents gets install which should be removed from VHD so that VHD can be consumed across platform (Azure, Azure Stack)

Issue Fixed:
Fixes #2086

Requirements:

Notes:

@rjaini rjaini requested a review from marosset October 2, 2019 19:34
@acs-bot acs-bot added the size/M label Oct 2, 2019
@jackfrancis jackfrancis changed the title Bug: Remove Azure agent specific artifacts from windows vhd bug: Remove Azure agent specific artifacts from windows vhd Oct 2, 2019
@codecov
Copy link

codecov bot commented Oct 2, 2019

Codecov Report

Merging #2088 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #2088      +/-   ##
=========================================
- Coverage   76.65%   76.6%   -0.05%     
=========================================
  Files         135     135              
  Lines       20576   20606      +30     
=========================================
+ Hits        15773   15786      +13     
- Misses       3881    3897      +16     
- Partials      922     923       +1

@rjaini rjaini changed the title bug: Remove Azure agent specific artifacts from windows vhd [WIP]: Remove Azure agent specific artifacts from windows vhd Oct 3, 2019
@acs-bot acs-bot added size/XS and removed size/M labels Oct 3, 2019
@marosset
Copy link
Contributor

marosset commented Oct 3, 2019

/lgtm

@rjaini rjaini changed the title [WIP]: Remove Azure agent specific artifacts from windows vhd Bug: Remove Azure agent specific artifacts from windows vhd Oct 3, 2019
@mboersma mboersma changed the title Bug: Remove Azure agent specific artifacts from windows vhd fix: remove Azure agent specific artifacts from windows vhd Oct 3, 2019
Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm++

@acs-bot
Copy link

acs-bot commented Oct 3, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marosset, mboersma, rjaini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@acs-bot acs-bot merged commit 7a8dc11 into Azure:master Oct 3, 2019
@rjaini rjaini deleted the winpacker branch October 11, 2019 18:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Azure agent artifacts from windows VHD
4 participants